fix assert firing in line 695 in debug builds#9338
Merged
daxian-dbw merged 2 commits intoPowerShell:masterfrom Apr 18, 2019
Merged
fix assert firing in line 695 in debug builds#9338daxian-dbw merged 2 commits intoPowerShell:masterfrom
daxian-dbw merged 2 commits intoPowerShell:masterfrom
Conversation
adityapatwardhan
approved these changes
Apr 10, 2019
TravisEz13
approved these changes
Apr 10, 2019
daxian-dbw
approved these changes
Apr 10, 2019
Member
daxian-dbw
left a comment
There was a problem hiding this comment.
LGTM with a minor comment.
The if branch above should have included MacOS
7930234 to
f751046
Compare
TravisEz13
approved these changes
Apr 18, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
ifbranch in line 636 should have included MacOSPR Summary
Stop the assert fire in debug builds on MacOS
PR Context
PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:or[ WIP ]to the beginning of the title (theWIPbot will keep its status check atPendingwhile the prefix is present) and remove the prefix when the PR is ready.