Run Codeformatter for SMA by iSazonov · Pull Request #9402 · PowerShell/PowerShell

iSazonov · 2019-04-18T06:41:27Z

PR Summary

Fix formatting issues in SMA with CodeFormatter.

Please review commit by commit.

PR Context

PR Checklist

src/System.Management.Automation/CoreCLR/CorePsStub.cs

SteveL-MSFT · 2019-04-19T04:30:13Z

src/System.Management.Automation/engine/CoreAdapter.cs

-                    var isHidden = cacheEntry.member.GetCustomAttributes(typeof(HiddenAttribute), false).Any();
-                    return new PSProperty(cacheEntry.member.Name, this, obj, cacheEntry) { IsHidden = isHidden } as T;
-                }
+                    {


Seems odd to have the brace indented particularly since the brace isn't even needed

SteveL-MSFT · 2019-04-19T04:32:11Z

src/System.Management.Automation/engine/Modules/ModuleCmdletBase.cs

-                                // if it points to a directory, add the basename back onto the path...
-                                qualifiedPath = Path.Combine(qualifiedPath, Path.GetFileName(fileBaseName));
-                            }
+                string qualifiedPath = Path.Combine(path, fileBaseName);


This change seems to make the code harder to read since it's optimizing for the non-Unix case

SteveL-MSFT · 2019-04-19T04:33:04Z

src/System.Management.Automation/engine/Modules/ModuleCmdletBase.cs

                            moduleSpecification.Name,
                            rootedPath, // fileBaseName
-                            /*extension*/null,
+                                        /*extension*/null,


this shouldn't be indented so far. would be better to have the comment at the end like the others or even better change this to use named params

src/System.Management.Automation/engine/MshCmdlet.cs

src/System.Management.Automation/engine/parser/TypeInferenceVisitor.cs

SteveL-MSFT · 2019-04-19T04:37:57Z

src/System.Management.Automation/engine/parser/TypeInferenceVisitor.cs

-                            res.Add(new PSTypeName(typeConstraint.TypeName));
-                            typeConstraintAdded = true;
-                        }
+                            if (!typeConstraintAdded)


here as well, overly indented

SteveL-MSFT · 2019-04-19T04:38:14Z

src/System.Management.Automation/engine/parser/TypeInferenceVisitor.cs

+                    case AttributeAst attributeAst:
                        {
-                        }
+                            PSTypeNameAttribute attribute = null;


same, other cases below

SteveL-MSFT · 2019-04-19T04:40:05Z

src/System.Management.Automation/engine/remoting/server/ServerPowerShellDriver.cs

-        // associated with this powershell
-        // data structure handler object to handle all
-        // communications with the client
+                                                                   // that is associated with this


should probably reformat this comment altogether to just a few lines

All comments in the code block was reformatted.

SteveL-MSFT · 2019-04-19T04:40:45Z

src/System.Management.Automation/security/SecuritySupport.cs

-                {
-                    if (policy == ExecutionPolicy.Undefined)
-                        executionPolicy = null;
+                    {


overly indented

SteveL-MSFT · 2019-04-23T02:38:20Z

src/System.Management.Automation/engine/parser/TypeInferenceVisitor.cs

-                            properties = new[] { stringConstant.Value };
-                            break;
-                        }
+                            {


should just remove the braces in whole file

Whole file was fixed.

* return correct casing of filesystem path during normalization * handle UNC case * handle case to add trailing separator back * add support for NTFS streams syntax * add case-sensitive test * only apply correct casing to directories * handle 8.3 path syntax * fix short path processing * Remove elements which do not work on earlier version on Windows PowerShell (#9411) * Use `Environment.NewLine` for new lines in `ConsoleHost` code (#9392) * Run CodeFormatter for Eventing (#9394) * Run CodeFormatter for MarkdownRender (#9398) * Run CodeFormatter for Security module (#9399) * Run CodeFormatter for WSMan.Runtime (#9401) * Run CodeFormatter for WSMan.Management (#9400) * Allow CI to run on branches with this name pattern: feature* (#9415) * Run CodeFormatter with BraceNewLine,UsingLocation,FormatDocument,NewLineAbove rules (#9393) * Build(deps): Bump NJsonSchema from 9.13.30 to 9.13.34 (#9421) * Build(deps): Bump NJsonSchema from 9.13.34 to 9.13.35 (#9429) Bumps [NJsonSchema](https://github.com/rsuter/NJsonSchema) from 9.13.34 to 9.13.35. - [Release notes](https://github.com/rsuter/NJsonSchema/releases) - [Commits](https://github.com/rsuter/NJsonSchema/commits) Signed-off-by: dependabot[bot] <[email protected]> * Build(deps): Bump Newtonsoft.Json (#9431) Bumps [Newtonsoft.Json](https://github.com/JamesNK/Newtonsoft.Json) from 12.0.1 to 12.0.2. - [Release notes](https://github.com/JamesNK/Newtonsoft.Json/releases) - [Commits](JamesNK/Newtonsoft.Json@12.0.1...12.0.2) Signed-off-by: dependabot[bot] <[email protected]> * Build(deps): Bump Newtonsoft.Json from 12.0.1 to 12.0.2 (#9434) Bumps [Newtonsoft.Json](https://github.com/JamesNK/Newtonsoft.Json) from 12.0.1 to 12.0.2. - [Release notes](https://github.com/JamesNK/Newtonsoft.Json/releases) - [Commits](JamesNK/Newtonsoft.Json@12.0.1...12.0.2) Signed-off-by: dependabot[bot] <[email protected]> * Add Preview assets for msix (#9375) * Adding tests for `Remove-Module` (#9276) * Build(deps): Bump gulp from 4.0.0 to 4.0.1 in /test/common/markdown (#9441) * Move warning message to EndProcessing so it only shows up once (#9385) * Run Codeformatter for SMA (#9402) * Fix the failed test and update 'Publish-TestResults' to make AzDO fail the task when any tests failed (#9457) * Enable building on Kali Linux (#9471) * Build test packages for windows, linux-x64, linux-arm, linux-arm64 and macOS (#9476) * Build(deps): Bump NJsonSchema from 9.13.35 to 9.13.36 (#9478) * Update Release_Process.md Add item for global tool Co-authored-by: Steve Lee <[email protected]> Co-authored-by: Steve Lee (POWERSHELL) <[email protected]> Co-authored-by: Aditya Patwardhan <[email protected]> Co-authored-by: Ilya <[email protected]> Co-authored-by: Dongbo Wang <[email protected]> Co-authored-by: null <dependabot[bot]@users.noreply.github.com> Co-authored-by: pougetat <[email protected]> Co-authored-by: Andrew <[email protected]>

iSazonov added 5 commits April 18, 2019 11:17

Step1

d36a4ca

Step 2

e9b049a

Step 3

f715af6

Step 4

6bf6082

Step 5

f48fd6f

iSazonov added the CL-CodeCleanup Indicates that a PR should be marked as a Code Cleanup change in the Change Log label Apr 18, 2019

iSazonov added this to the 7.0.0-preview.1 milestone Apr 18, 2019

iSazonov requested review from PaulHigin, SteveL-MSFT, TravisEz13, TylerLeonhardt, adityapatwardhan, anmenaga and daxian-dbw April 18, 2019 06:41

iSazonov requested review from BrucePay, Francisco-Gamino and mirichmo as code owners April 18, 2019 06:41

Manual style fixes

4eac412

SteveL-MSFT requested changes Apr 19, 2019

View reviewed changes

iSazonov added 7 commits April 22, 2019 13:43

Fix switch in CoreAdapter.cs

e7fd5b6

Fix /ModuleCmdletBase.cs

f990415

Fix Utils.cs

022f520

Reformat comments in ServerPowerShellDriver.cs

c17f9aa

Fix SecuritySupport.cs

aa6c638

Fix TypeInferenceVisitor.cs

a809045

Fixed TypeInferenceVisitor.cs 2

0f48fd8

SteveL-MSFT requested changes Apr 23, 2019

View reviewed changes

iSazonov added 2 commits April 23, 2019 08:19

Fix TypeInferenceVisitor.cs 3

96bf7f2

Fix CorePsStub.cs 2

3fa0fa7

SteveL-MSFT approved these changes Apr 24, 2019

View reviewed changes

iSazonov self-assigned this Apr 24, 2019

iSazonov merged commit ceed73d into PowerShell:master Apr 24, 2019

iSazonov deleted the codeformatter-sma-1 branch April 24, 2019 14:27

Conversation

iSazonov commented Apr 18, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR Summary

PR Context

PR Checklist

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

iSazonov Apr 22, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

SteveL-MSFT Apr 23, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

iSazonov commented Apr 18, 2019 •

edited

Loading

iSazonov Apr 22, 2019 •

edited

Loading

SteveL-MSFT Apr 23, 2019 •

edited

Loading