Fix Get-Runspace runspace object format Type column#9438
Merged
adityapatwardhan merged 3 commits intoPowerShell:masterfrom May 1, 2019
PaulHigin:fix-runspace-format-type
Merged
Fix Get-Runspace runspace object format Type column#9438adityapatwardhan merged 3 commits intoPowerShell:masterfrom PaulHigin:fix-runspace-format-type
adityapatwardhan merged 3 commits intoPowerShell:masterfrom
PaulHigin:fix-runspace-format-type
Conversation
Member
|
@PaulHigin Is it possible to add a test? |
Contributor
Author
|
Since we didn't have a test for this before, I would argue that we don't need to add one now. I think in general we don't test formatted output, but only that formatting and output work functionally. |
TravisEz13
approved these changes
Apr 23, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This addresses issue #9341.
Any runspace that uses a RunspaceConnectionInfo object is a remote (proxy) runspace, and should be marked 'Remote' instead of 'Local'. Currently only WSMan runspaces are marked 'Remote', and this change fixes that.
PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:or[ WIP ]to the beginning of the title (theWIPbot will keep its status check atPendingwhile the prefix is present) and remove the prefix when the PR is ready.