Ensure Wait-UntilTrue returns $true in Pester tests#9458
Merged
adityapatwardhan merged 5 commits intoPowerShell:masterfrom May 2, 2019
Merged
Ensure Wait-UntilTrue returns $true in Pester tests#9458adityapatwardhan merged 5 commits intoPowerShell:masterfrom
adityapatwardhan merged 5 commits intoPowerShell:masterfrom
Conversation
* Ensure Wait-UntilTrue returns $true in Pester tests * Mark a ConvertTo-Json test as Pendingc due to test failure
Contributor
Author
|
Test failure on PowerShell-CI-linux appears to be unrelated to this PR, probably caused by #9250. |
iSazonov
reviewed
Apr 25, 2019
test/powershell/Language/Scripting/Debugging/Debugging.Tests.ps1
Outdated
Show resolved
Hide resolved
Use `Should -BeTrue` instead of `Should -BeExactly $true`.
iSazonov
reviewed
Apr 26, 2019
test/powershell/Modules/Microsoft.PowerShell.Utility/ConvertTo-Json.Tests.ps1
Show resolved
Hide resolved
TravisEz13
reviewed
Apr 26, 2019
| } | ||
| # Wait | ||
| Start-Sleep -Milliseconds $intervalInMilliseconds | ||
| Start-Sleep -Milliseconds $intervalInMilliseconds > $null |
Member
There was a problem hiding this comment.
This should not be needed, but won't hurt anything
iSazonov
approved these changes
Apr 26, 2019
Collaborator
iSazonov
left a comment
There was a problem hiding this comment.
LGTM with one request to open a tracking issue.
Contributor
Author
|
Opened #9489 for |
adityapatwardhan
approved these changes
May 2, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
PR Context
Pester tests should check if the function Wait-UntilTrue actually returns $true rather than timing out.
PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:or[ WIP ]to the beginning of the title (theWIPbot will keep its status check atPendingwhile the prefix is present) and remove the prefix when the PR is ready.