Update use of Windows PowerShell to just PowerShell in our logging#9508
Update use of Windows PowerShell to just PowerShell in our logging#9508iSazonov merged 1 commit intoPowerShell:masterfrom
Windows PowerShell to just PowerShell in our logging#9508Conversation
|
@SteveL-MSFT Previously we already fixed this by replacing Windows PowerShell with PowerShell Core in all code base. All changes in the PR is related to Windows code. I think it makes no sense to change something in the Windows only code. |
|
Specifically, the PowerShell.Core.Instrumentation.man manifest for ETW events uses Windows PowerShell when it should have used just PowerShell. This is Windows specific, but not Windows PowerShell specific. |
|
If we previously replaced Windows PowerShell with PowerShell Core should we now replace PowerShell Core with PowerShell? |
|
@iSazonov We should probably replace them where it's not important to differentiate that it's Core. I'll review the instances and add it to this PR. |
|
Turns out there's a lot more instances of PowerShell Core, so doing that as a separate PR |
PR Summary
Some cases where we log on non-Windows and it mentions Windows PowerShell when it's not specific about Windows PowerShell. Searched for occurrences of
Windows PowerShellin our code base and changed the ones that can be genericPowerShell. VSCode fixed some whitespace issues and saw some typos in a comment I fixed at the same time.PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:or[ WIP ]to the beginning of the title (theWIPbot will keep its status check atPendingwhile the prefix is present) and remove the prefix when the PR is ready.