Skip to content

Port debian and opensuse to preview channel#99

Merged
TravisEz13 merged 9 commits intoPowerShell:masterfrom
TravisEz13:port_stable_images_to_preview
Dec 13, 2018
Merged

Port debian and opensuse to preview channel#99
TravisEz13 merged 9 commits intoPowerShell:masterfrom
TravisEz13:port_stable_images_to_preview

Conversation

@TravisEz13
Copy link
Copy Markdown
Member

@TravisEz13 TravisEz13 commented Dec 12, 2018

PR Summary

Port debian and opensuse to preview channel

PR Checklist

@TravisEz13 TravisEz13 requested a review from anmenaga as a code owner December 12, 2018 00:07
@TravisEz13
Copy link
Copy Markdown
Member Author

@kiazhi Would you mind looking over these changes? They are almost a direct port from the stable images. Feel free to say no if you don't have time or aren't interested.

@kiazhi
Copy link
Copy Markdown
Contributor

kiazhi commented Dec 12, 2018

@TravisEz13 sure, i will have a look during the next few days since i'm leaving my current job and relocating soon to find a new job next year.

Copy link
Copy Markdown
Contributor

@kiazhi kiazhi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will look at openSUSE 42.3 tomorrow. There are a few lines that need fixing which I already noticed but its the end of the day time for me now.

@TravisEz13
Copy link
Copy Markdown
Member Author

cc @PaulHigin FYI, this might not be a great one to start with.
@kiazhi Thanks, great feedback. I might merge before I get the rest, but feel free to finish your feedback. I'm happy to finish in another PR.

Copy link
Copy Markdown
Contributor

@kiazhi kiazhi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed openSUSE 42.3 for preview release.

Copy link
Copy Markdown

@PaulHigin PaulHigin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@TravisEz13
Copy link
Copy Markdown
Member Author

I only saw the location change for the cache when reviewing with Paul. I think that is a good idea. Could you file an issue for that?

@TravisEz13 TravisEz13 merged commit 7f6699f into PowerShell:master Dec 13, 2018
@TravisEz13 TravisEz13 deleted the port_stable_images_to_preview branch December 13, 2018 00:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants