Prevent Update Notebook dts action from triggering on forked repositories#2871
Merged
TylerLeonhardt merged 4 commits intoPowerShell:masterfrom Aug 6, 2020
corbob:stop-the-fork-PRs
Merged
Prevent Update Notebook dts action from triggering on forked repositories#2871TylerLeonhardt merged 4 commits intoPowerShell:masterfrom corbob:stop-the-fork-PRs
Update Notebook dts action from triggering on forked repositories#2871TylerLeonhardt merged 4 commits intoPowerShell:masterfrom
corbob:stop-the-fork-PRs
Conversation
Member
|
I was kinda hoping this would prevent the entire action from running. In the other PR the Can you follow that? |
Put the check in the overall definition so none of the workflow runs if not the main repository.
Contributor
Author
|
I've moved the if up to the steps level. I tried it in the on level, but it didn't like that. I also added it to the codeql workflow so it too only runs on the main repository. From my testing it works: Edit for completeness: I configured the schedule in my master branch to run every 10 minutes, and it was skipped: This means that actions will be showing up in forked repos, but they won't run... I guess that's about the best we can do 🤷 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Similar to PowerShell/PowerShell#12763
PR Summary
Update GitHub Actions Workflow to only trigger on the main vscode-powershell repository.
Note: I have not tested this, merely modeled it after the documentation and the PowerShell PR.
PR Checklist