Merged
Conversation
caleeli
approved these changes
Nov 22, 2023
|
SonarQube Quality Gate |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.








Issue & Reproduction Steps
Packages that were disabled via licenses are being re-enabled after install
Solution
If the bootstrap/config/packges.php gets re-built before our custom
LicensedPackageManifestis registered, the all packages will be enabled regardless of the license. This happens on several cache commands, such asclear-compiled, or if the package.php file is removed, which is whatoptimize:cleardoes.clear-compiledwhen settings change.clear-compiledwill remove other cached files (like packages.php, which is responsible for the license restrictions). Theconfig:cachethat runs after is sufficient.processmaker:license-removeso all packages are available again when the license is removed.optimize:clearcallsoptimizeonly once and only after packages are installed and before the license is installed. Otherwise, optimize will disabled the licenses by overwriting packages.phpHow to Test
Describe how to test that this solution works.
Related Tickets & Packages
Requires
Code Review Checklist