Skip to content

FOUR-12594 Request Columns final order#5775

Merged
caleeli merged 3 commits intofeature/FOUR-11530from
feature/FOUR-12594
Dec 6, 2023
Merged

FOUR-12594 Request Columns final order#5775
caleeli merged 3 commits intofeature/FOUR-11530from
feature/FOUR-12594

Conversation

@caleeli
Copy link
Copy Markdown
Contributor

@caleeli caleeli commented Dec 6, 2023

Request Columns final order

Related Tickets & Packages

Code Review Checklist

  • I have pulled this code locally and tested it on my instance, along with any associated packages.
  • This code adheres to ProcessMaker Coding Guidelines.
  • This code includes a unit test or an E2E test that tests its functionality, or is covered by an existing test.
  • This solution fixes the bug reported in the original ticket.
  • This solution does not alter the expected output of a component in a way that would break existing Processes.
  • This solution does not implement any breaking changes that would invalidate documentation or cause existing Processes to fail.
  • This solution has been tested with enterprise packages that rely on its functionality and does not introduce bugs in those packages.
  • This code does not duplicate functionality that already exists in the framework or in ProcessMaker.
  • This ticket conforms to the PRD associated with this part of ProcessMaker.

ci:next
ci:deploy

@@ -339,7 +365,7 @@ export default {
this.page +
"&per_page=" +
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why is removed the "&" in this section?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It wasn't removed.
Seems github is highlighting it in red 🤔

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very strange

@caleeli caleeli force-pushed the feature/FOUR-12594 branch from 7606fe7 to 9247aae Compare December 6, 2023 17:30
@processmaker-sonarqube
Copy link
Copy Markdown

Copy link
Copy Markdown
Contributor

@julceslauhub julceslauhub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

@caleeli caleeli merged commit 50000a3 into feature/FOUR-11530 Dec 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants