Skip to content

FOUR-13942 the kill existing session in device restriction is not working correctly#6153

Merged
ryancooley merged 1 commit intonextfrom
bugfix/FOUR-13942
Feb 6, 2024
Merged

FOUR-13942 the kill existing session in device restriction is not working correctly#6153
ryancooley merged 1 commit intonextfrom
bugfix/FOUR-13942

Conversation

@devmiguelangel
Copy link
Copy Markdown
Contributor

@devmiguelangel devmiguelangel commented Feb 5, 2024

Issue & Reproduction Steps

The Kill existing session option in device restriction is not working correctly.
There are times when both browsers are in session, sometimes if the existing session is checked

Solution

  • Run session control kill middleware before the BROWSER_CACHE middleware

How to Test

  1. Log in
  2. Go to Admin
  3. Click on Settings
  4. Enter Session Control
  5. In Device Restriction choose the option Kill existing session
  6. Login in a browser with a user
  7. Login with the same user in another browser
  8. We return to the first browser
  9. We refresh or enter an option in the application

Related Tickets & Packages

Code Review Checklist

  • I have pulled this code locally and tested it on my instance, along with any associated packages.
  • This code adheres to ProcessMaker Coding Guidelines.
  • This code includes a unit test or an E2E test that tests its functionality, or is covered by an existing test.
  • This solution fixes the bug reported in the original ticket.
  • This solution does not alter the expected output of a component in a way that would break existing Processes.
  • This solution does not implement any breaking changes that would invalidate documentation or cause existing Processes to fail.
  • This solution has been tested with enterprise packages that rely on its functionality and does not introduce bugs in those packages.
  • This code does not duplicate functionality that already exists in the framework or in ProcessMaker.
  • This ticket conforms to the PRD associated with this part of ProcessMaker.

ci:next
ci:deploy

@tokensPM
Copy link
Copy Markdown

tokensPM commented Feb 5, 2024

QA server K8S was successfully deployed https://ci-cb978b3935.engk8s.processmaker.net

@processmaker-sonarqube
Copy link
Copy Markdown

@tokensPM
Copy link
Copy Markdown

tokensPM commented Feb 5, 2024

QA server K8S was successfully deployed https://ci-cb978b3935.engk8s.processmaker.net

@devmiguelangel devmiguelangel self-assigned this Feb 5, 2024
@pmPaulis
Copy link
Copy Markdown
Contributor

pmPaulis commented Feb 5, 2024

@devmiguelangel
This is working fine when the devices are Mozilla and Chrome
image
Other instances from Chrome/Mozilla like incognito is not considered different

@ryancooley ryancooley merged commit 3a0e3f7 into next Feb 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants