Skip to content

FOUR-13914 | The Language Selected for a User Is Not Complete#6201

Merged
ryancooley merged 2 commits intonextfrom
observation/FOUR-13914-b
Feb 14, 2024
Merged

FOUR-13914 | The Language Selected for a User Is Not Complete#6201
ryancooley merged 2 commits intonextfrom
observation/FOUR-13914-b

Conversation

@mcraeteisha
Copy link
Copy Markdown
Contributor

@mcraeteisha mcraeteisha commented Feb 9, 2024

Issue

Ticket: FOUR-13914

When a language is selected for a user, all strings are not translated into the selected language.

Solution

  • Ensure missing translations are wrapped in the $t(...) translation method.
  • Ensure missing translations are added to the language JSON files.

How to Test

  1. Go to branch observation/FOUR-13914-b in processmaker.
  2. Go to branch observation/FOUR-13914-b in screen-builder.
  3. Create a user. Change their language to es for Spanish.
  4. Ensure that the text on the following pages is translated into Spanish:
    • Homepage (Custom Dashboard text)
    • Processes
    • Designer

ci:next

Code Review Checklist

  • I have pulled this code locally and tested it on my instance, along with any associated packages.
  • This code adheres to ProcessMaker Coding Guidelines.
  • This code includes a unit test or an E2E test that tests its functionality, or is covered by an existing test.
  • This solution fixes the bug reported in the original ticket.
  • This solution does not alter the expected output of a component in a way that would break existing Processes.
  • This solution does not implement any breaking changes that would invalidate documentation or cause existing Processes to fail.
  • This solution has been tested with enterprise packages that rely on its functionality and does not introduce bugs in those packages.
  • This code does not duplicate functionality that already exists in the framework or in ProcessMaker.
  • This ticket conforms to the PRD associated with this part of ProcessMaker.

@processmaker-sonarqube
Copy link
Copy Markdown

Quality Gate passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No Coverage information No data about Coverage
0.0% 0.0% Duplication on New Code

See analysis details on SonarQube

@ryancooley ryancooley merged commit ee92cf9 into next Feb 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants