Skip to content

QA Observation Bugfix/FOUR-14155: You cannot filter using "between" from the second page#6227

Merged
ryancooley merged 4 commits intonextfrom
bugfix/FOUR-14155
Feb 16, 2024
Merged

QA Observation Bugfix/FOUR-14155: You cannot filter using "between" from the second page#6227
ryancooley merged 4 commits intonextfrom
bugfix/FOUR-14155

Conversation

@CarliPinell
Copy link
Copy Markdown
Contributor

@CarliPinell CarliPinell commented Feb 15, 2024 •
edited
Loading

Solution

This ticket fixes issue with filter between in second page in Requests

How to Test

Go to Requests, add between filter in STARTED column

Related Tickets & Packages

https://processmaker.atlassian.net/browse/FOUR-14155

Code Review Checklist

  • I have pulled this code locally and tested it on my instance, along with any associated packages.
  • This code adheres to ProcessMaker Coding Guidelines.
  • This code includes a unit test or an E2E test that tests its functionality, or is covered by an existing test.
  • This solution fixes the bug reported in the original ticket.
  • This solution does not alter the expected output of a component in a way that would break existing Processes.
  • This solution does not implement any breaking changes that would invalidate documentation or cause existing Processes to fail.
  • This solution has been tested with enterprise packages that rely on its functionality and does not introduce bugs in those packages.
  • This code does not duplicate functionality that already exists in the framework or in ProcessMaker.
  • This ticket conforms to the PRD associated with this part of ProcessMaker.
    ci:deploy
    ci:next

@CarliPinell CarliPinell changed the title QA Observation Bugfix/FOUR-14155: QA Observation Bugfix/FOUR-14155: You cannot filter using "between" from the second page Feb 15, 2024
@CarliPinell CarliPinell requested a review from pmPaulis February 15, 2024 19:15
gustavobascope
gustavobascope approved these changes Feb 15, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@gustavobascope gustavobascope left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No observations

@tokensPM
Copy link
Copy Markdown

tokensPM commented Feb 15, 2024

QA server K8S was successfully deployed https://ci-a3330cff72.engk8s.processmaker.net

@gproly
Copy link
Copy Markdown
Contributor

gproly commented Feb 15, 2024 •
edited
Loading

Analyzing this change, this behavior should also be appearing in the 'Tasks' listing. Please review the 'page' property in files 'resources/js/requests/components/RequestsListing.vue' and 'resources/js/tasks/components/ListMixin.js'.

The correct logic would be:

  • if the filter settings for any column change, then the 'page' property should be set to 1. If the filter settings remain the same, then 'page' should not change, enabling navigation between pages.

The function you should analyze is 'resources/js/common/PMColumnFilterPopoverCommonMixin.js -> storeFilterConfiguration()'; this is where the configuration is saved. It is only necessary to consider the 'filters' variable in this function.

Please let's consider analyzing alternative solutions that Nolan can provide us with, thank you.

gproly
gproly requested changes Feb 15, 2024
View reviewed changes
@CarliPinell
Copy link
Copy Markdown
Contributor Author

CarliPinell commented Feb 15, 2024

The problem that was detected is that when a filter is used on page 2 or subsequent pages, the result is sent to page 1, but the screen remains on page 2, showing that no results were found. But if you go back to page 1, the filter results are found.

@tokensPM
Copy link
Copy Markdown

tokensPM commented Feb 15, 2024

QA server K8S was successfully deployed https://ci-a3330cff72.engk8s.processmaker.net

nolanpro
nolanpro previously requested changes Feb 16, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@nolanpro nolanpro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@CarliPinell I think you need to add previousAdvancedFilter to resources/js/tasks/components/TasksList.vue in the data() method

@gproly gproly self-requested a review February 16, 2024 07:48
@processmaker-sonarqube
Copy link
Copy Markdown

processmaker-sonarqube bot commented Feb 16, 2024

Quality Gate passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
0.0% 0.0% Coverage on New Code
0.0% 0.0% Duplication on New Code

See analysis details on SonarQube

@gproly
Copy link
Copy Markdown
Contributor

gproly commented Feb 16, 2024 •
edited
Loading

I have added the variable 'previousAdvancedFilter' in file 'resources/js/tasks/components/TasksList.vue', so this would be approved. Thank you. @CarliPinell @nolanpro

@tokensPM
Copy link
Copy Markdown

tokensPM commented Feb 16, 2024

QA server K8S was successfully deployed https://ci-a3330cff72.engk8s.processmaker.net

@ryancooley ryancooley merged commit b635de1 into next Feb 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gproly gproly gproly approved these changes

@gustavobascope gustavobascope gustavobascope approved these changes

@nolanpro nolanpro nolanpro left review comments

@pmPaulis pmPaulis Awaiting requested review from pmPaulis

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@CarliPinell @tokensPM @gproly @nolanpro @gustavobascope @ryancooley