Skip to content

FOUR-13564: POC for Notification Integration#6864

Merged
estebangallego merged 2 commits intofeature/FOUR-15584from
task/FOUR-13564-a
May 29, 2024
Merged

FOUR-13564: POC for Notification Integration#6864
estebangallego merged 2 commits intofeature/FOUR-15584from
task/FOUR-13564-a

Conversation

@estebangallego
Copy link
Copy Markdown
Contributor

Issue & Reproduction Steps

When installing the phrity/websocket package within the IDP Connector, an error in versioning occurs.

phrity/websocket[2.1.0, ..., 2.1.3] require psr/log ^1.0 | ^2.0 -> found psr/log[1.0.0, ..., 1.1.4, 2.0.0] but the package is fixed to 3.0.0 (lock file version) by a partial update and that version does not match.

Solution

  • Downgrade require psr/log to version ^2.0

How to Test

  • Ensure that the IDP Connector is properly installed with no errors.
  • Ensure that psr 2.0 is installed composer require psr/log:^2.0
  • Ensure no errors occur when running composer install in Core.

Related Tickets & Packages

Code Review Checklist

  • I have pulled this code locally and tested it on my instance, along with any associated packages.
  • This code adheres to ProcessMaker Coding Guidelines.
  • This code includes a unit test or an E2E test that tests its functionality, or is covered by an existing test.
  • This solution fixes the bug reported in the original ticket.
  • This solution does not alter the expected output of a component in a way that would break existing Processes.
  • This solution does not implement any breaking changes that would invalidate documentation or cause existing Processes to fail.
  • This solution has been tested with enterprise packages that rely on its functionality and does not introduce bugs in those packages.
  • This code does not duplicate functionality that already exists in the framework or in ProcessMaker.
  • This ticket conforms to the PRD associated with this part of ProcessMaker.

@eiresendez eiresendez self-requested a review May 21, 2024 16:22
@estebangallego estebangallego changed the base branch from next to feature/FOUR-15584 May 29, 2024 18:56
@processmaker-sonarqube
Copy link
Copy Markdown

Quality Gate passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No Coverage information No data about Coverage
No Duplication information No data about Duplication

See analysis details on SonarQube

@estebangallego estebangallego merged commit 5eb65e8 into feature/FOUR-15584 May 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants