FOUR-18323 | Implement CSS Application Logic#7383
Merged
sanjacornelius merged 4 commits intoepic/FOUR-18012from Sep 20, 2024
Merged
FOUR-18323 | Implement CSS Application Logic#7383sanjacornelius merged 4 commits intoepic/FOUR-18012from
sanjacornelius merged 4 commits intoepic/FOUR-18012from
Conversation
|
QA server K8S was successfully deployed https://ci-64f7fdb310.engk8s.processmaker.net |
estebangallego
approved these changes
Sep 19, 2024
Contributor
estebangallego
left a comment
There was a problem hiding this comment.
Works as expected!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Feature
Ticket: FOUR-18323
This PR introduces logic for Applying CSS to Screens via the Screen Templates Panel in
screen-builder.When a user chooses to only apply CSS from a template to their screen:
If the template introduces CSS elements, they will be added to the existing screen CSS.
If the template has the same CSS elements as the existing screen, it will replace them with the CSS elements from the template.
If both, screen and template, share CSS elements but the template adds new styles or properties, they should be added to the existing screen individually.
How to Test
Go to branch
task/FOUR-18323inscreen-builderandprocessmaker.Ensure you have a Screen Template with Custom CSS in your environment.
Create a new screen in the Screen Builder.
Select 'Templates'. Select the template card for the Screen Template that has CSS.
Select 'CSS'.
Update the CSS in your template and in your screen so that they have the same CSS elements with different properties. For example:
[selector="my-selector"] {background-color: red;}[selector="my-selector"] {background-color: blue; }Save the Screen and the Template.
In your Screen, select the template again and select 'CSS'.
Update the CSS in your template and in your screen so that they have the same CSS element with different properties. For example:
Screen CSS:
div > p [selector="test-selector"] { border: 1px solid red; }Template CSS:
div > p [selector="test-selector"] { background-color: red; font-size: 12px; }Save the Screen and the Template.
In your Screen, select the template again and select 'CSS'.
div > p [selector="test-selector"] { border: 1px solid red; background-color: red; font-size: 12px; }ci:next
ci:screen-builder:task/FOUR-18323
ci:deploy
Code Review Checklist