Bugfix/FOUR-5139: It is not possible to add a record in a loop (4.2)#1174
Merged
Bugfix/FOUR-5139: It is not possible to add a record in a loop (4.2)#1174
Conversation
…n computed field to ensure it returns the appropriate data (if any)
… bugfix/FOUR-5139
agustinbusso
approved these changes
Feb 17, 2022
Contributor
agustinbusso
left a comment
There was a problem hiding this comment.
Working for all related issues (FOUR-5139, FOUR-5161, FOUR-5086, FOUR-5403)
Working videos
Screen.Recording.2022-02-17.at.09.57.49.mov
Screen.Recording.2022-02-17.at.09.59.55.mov
Screen.Recording.2022-02-17.at.10.13.00.mov
Screen.Recording.2022-02-17.at.10.19.45.mov
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue & Reproduction Steps
Create Screen
Add loop with this configuration:
Add a line input inside a loop
Create a calc with the next code:
Press preview button
Put the following JSON in data input:
Expected behavior:
By clicking the "+" or "Add Row" button in the loop, an additional line input would be added.
Actual behavior:
Clicking the "+" does nothing in the current configuration but changing the data input does allow another line input to be added.
Solution
How to Test
You should be able to follow the repoduction steps after this PR and successfully add rows by using the "+" or "Add Row" button to the loop. Same goes for the "-" or "Delete Row" button.
Related Tickets & Packages
Code Review Checklist