Fix deadpool announcement transaction selection + other fixes#39
Merged
ReverseControl merged 2 commits intoProjectFactor:mainfrom Feb 2, 2025
Merged
Fix deadpool announcement transaction selection + other fixes#39ReverseControl merged 2 commits intoProjectFactor:mainfrom
ReverseControl merged 2 commits intoProjectFactor:mainfrom
Conversation
Collaborator
|
functional tests pass on macOS arm64 w/ apple clang 16 (after updating pinned boost to 1.86, I'll open a PR for that separately shortly) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In
BlockAssembler, the set of existing announcements (vIncludedAnnounces) isn't updated until a "package" of transactions is added to the assembled blockTherefore, when 2 announcements with same deadpool id appear in the same package of transactions, it slips through the existing
BlockAssembler::TestPackageTransactionscheck and makesContextualCheckBlockerror out withdp-mult-ann, more than one announcement for a single deadpool entry.This is causing existing versions of the node to fail to handle
getblocktemplaterequests, since there's currently 2 announcements on the same N in the mempool. This issue have brought down nearly all active miners on the network who upgraded their node.This PR fixes the issue by adding a
packageAnnouncesvariable inBlockAssembler::TestPackageTransactionsand using it to check if the same deadpool id appeared twice in the current packageSome additional fixes included in this PR:
CompareTxMemPoolEntryByAncestorBurnFeewhich was breaking transaction sorting by burnt fee#includedirectives, which were causing the node to fail to compile on newer GCC versions (for instance, it doesn't compile with GCC 14.2.1 without the fix)