Define and implement hard diff removal hardfork#41
Merged
ReverseControl merged 5 commits intoProjectFactor:mainfrom Jul 10, 2025
Merged
Define and implement hard diff removal hardfork#41ReverseControl merged 5 commits intoProjectFactor:mainfrom
ReverseControl merged 5 commits intoProjectFactor:mainfrom
Conversation
…en the block time outside of 15 ~ 60 minutes range
ReverseControl
requested changes
Jul 8, 2025
Contributor
ReverseControl
left a comment
There was a problem hiding this comment.
CalculateDifficultyDelta(): Most of those if statements got to go. We will use bit-operators and ternary operators. Almost every if statement in there is unnecessary.
ReverseControl
approved these changes
Jul 10, 2025
Contributor
ReverseControl
left a comment
There was a problem hiding this comment.
Approving for now as this has been tested. The optimizations will come in later.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Facts of the hard fork:
Concept of the new difficulty adjustment algorithm:
do {} while ();manner)do {} while ();manner)What's considered too short/long are identical to the original algorithm (<27 mins is too short, >31 mins is too long)
Introduce more aggressive difficulty adjustment when block time deviates far away (>2x) from 30 minutes:
Whether it's even or odd depends on whether the original difficulty were even or odd