Switch to FactWallet-specific data directories and add UI for semi-auto migration#24
Merged
ReverseControl merged 3 commits intoProjectFactor:masterfrom Apr 28, 2025
Merged
Conversation
ReverseControl
approved these changes
Apr 28, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
1: Change default data directory paths to use FactWallet-specific locations
~/.factwallet(was~/.electrum)%APPDATA%\FactWallet(was%APPDATA%\Electrum)factwallet_data(waselectrum_data)2: Migration UI
electrum/migration.py) that:blockchain_preferred_blockinconfigis a mainnet/testnet FACT0RN genesis block)Electrum-backupByFactWallet-20250426205619)3: Housekeeping
Testing Performed
Tested functionalities
The above testing was performed on:
Lastly, for the record, this is how I built the test binaries with Cirrus CLI locally:
docker build -t factwallet-ci-appimage .(in contrib/build-linux/appimage)~/Tools/cirrus-linux-amd64 run --dirty --lazy-pull --dockerfile-image-template=factwallet-ci-appimage "build: AppImage"docker build -t factwallet-ci-windows .(in contrib/build-wine)~/Tools/cirrus-linux-amd64 run --dirty --lazy-pull --dockerfile-image-template=factwallet-ci-windows "build: Windows"