This repository was archived by the owner on Jul 3, 2021. It is now read-only.
Added ProxyKitClient as optional argument#125
Merged
damianh merged 2 commits intoProxyKit:masterfrom Jun 30, 2019
Merged
Conversation
Collaborator
|
Thanks for PR! Will take a look shortly. |
Collaborator
|
I improved on the PR in a7623d9 . Instead, |
Author
|
That's perfect. Yeah, I only used the optional argument to be able to test the performance, the user should not need to deal with it. 👍 👍
/Anders (from phone)
On Sun, Jun 30, 2019 at 10:16 PM +0200, "Damian Hickey" <[email protected]> wrote:
I improved on the PR in a7623d9 . Instead, ProxyKitClient is injected into ProxyMiddleware and passed to the ForwardToContext via HttpContext.Items. This removes the need for the optional parameter and potentially confused users ("when do I use that?")
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.
|
damianh
added a commit
that referenced
this pull request
Jul 1, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Code discussed in #124
I moved the creation of ProxyKitClient outside of the forwarding hotpath since it uses reflection to generate httpClients