[MRG] Distance calculation bug solve#306
Merged
rflamary merged 5 commits intoPythonOT:masterfrom Nov 8, 2021
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #306 +/- ##
==========================================
+ Coverage 93.38% 93.43% +0.04%
==========================================
Files 21 21
Lines 4886 4888 +2
==========================================
+ Hits 4563 4567 +4
+ Misses 323 321 -2 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Types of changes
Motivation and context / Related issue
Resolves #305, also allows the usage of weights (otherwise wminkowski is not a valid metric contrary to what POT doc suggests)
How has this been tested (if it applies)
Tests ran locally without a hitch
Checklist