Conversation
Codecov Report❌ Patch coverage is
... and 4 files with indirect coverage changes 🚀 New features to boost your workflow:
|
|
Went a little crazy with this one after figuring out some of the rules needed modification for the Diagonal case where the output is by default the same as the input |
|
Your PR no longer requires formatting changes. Thank you for your contribution! |
|
This was a fun one, as a bunch of rules had to be modified to account for the case where one of the arguments |
lkdvos
left a comment
There was a problem hiding this comment.
Good catch, that does indeed sound like an absolute misery to debug/find and solve!
I left some small suggestions around code organization, mostly to reduce the amount of code and/or improve readability, but otherwise this looks great (I absolutely understand that the complexity might just be unavoidable, again, impressive catch on this!)
I'll go through the remainder afterwards if you like, but I will already leave this here to not get lost in a wall of questions :)
|
CUDA fail is unrelated, it's the CUSOLVER memory thing again |
Fix stupid typos Diagonal + eig(h) working SVD working for diag LQ/QR working Polar and orthnull Some Mooncake progress Formatter Working Mooncake eig Remove comment No diag for orthnull Diag tests working for Mooncake Formatter Update ext/MatrixAlgebraKitEnzymeExt/MatrixAlgebraKitEnzymeExt.jl Co-authored-by: Lukas Devos <[email protected]> A bit of Enzyme cleanup A little Mooncake cleanup
No description provided.