Convert code to swift 4#52
Closed
dpereira411 wants to merge 1 commit intoQueryKit:masterfrom
dpereira411:swift-4
Closed
Convert code to swift 4#52dpereira411 wants to merge 1 commit intoQueryKit:masterfrom dpereira411:swift-4
dpereira411 wants to merge 1 commit intoQueryKit:masterfrom
dpereira411:swift-4
Conversation
Member
|
Hi @dpereira411, now that Xcode 9 GM is available I think we can now get this PR ready to merge. Would you be able to update the code so that we can support both Swift 3 and Swift 4 at the same time, not everyone has the opportunity to migrate and it should be trivial to support both using Remaining Tasks
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.