Add numpy utilities and game data pre-processing#36
Add numpy utilities and game data pre-processing#36tarehart merged 6 commits intoRLBot:spikesprintfrom ViliamVadocz:spikesprint
Conversation
|
I like the idea of providing these utils for people who prefer to work with numpy. I'm concerned that it currently clashes with the rest of bot.py though because it's using the Vec3 class everywhere else. Would you be willing to change this so it's just np_data.py and np_utils.py, and leave bot.py alone to avoid confusing anyone? Or in bot.py you could just have a comment like "Do you prefer to work with numpy? If so, you can find some utils in [folder]" |
|
Good point, although if we plan to use RLU there will be clashes anyway. I moved the utilities to a separate folder and removed the example code from |
|
Great, thank you! Could you also remove the commented out code and make function names like a3v more descriptive? For RLU was thinking of making a nice little wrapper function for aerials that takes Vec3 args |
|
The commented out code is there so that you don't process things you don't use. If you do decide to use it you don't have to do any more work; just uncomment. |
|
Looks good, thanks Will! |
The utilities should be well documented and easy to use.