Conversation
anjali-deshpande-hub
left a comment
There was a problem hiding this comment.
-
assignment_1.ipynb file changes are on assignment-2 branch as well. This is probably because you branch assignment-2 from assignment-1
-
Question 2:
numpy is optimized to perform operations on entire arrays at once rather than iterating row by row in Python. So instead of iterating over the rows (patients) and applying mean, max/min on each row, you can directly apply numpy functions on entire array. Its more efficient that way. In other words, removefor patient in data:andsummary_values.append(np.mean(patient))and directly dosummary_values = np.mean(data, axis=ax) -
Question 3: You haven't used check_zeros function. Please code using the given function.
|
You have fixed items 2 and 3. Well done! |
anjali-deshpande-hub
left a comment
There was a problem hiding this comment.
Its fixed now. Very good!
|
Thank you Anjali!
Sent from my iPhone
On Dec 13, 2024, at 10:36 PM, anjali-deshpande-hub ***@***.***> wrote:
@anjali-deshpande-hub approved this pull request.
Its fixed now. Very good!
—
Reply to this email directly, view it on GitHub<#2 (review)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/BM5DMWZ3VFSLS3BWHZ7DJOL2FORTTAVCNFSM6AAAAABTHZFEOOVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDKMBTGUYDKNBYGQ>.
You are receiving this because you authored the thread.Message ID: ***@***.***>
|
What changes are you trying to make? (e.g. Adding or removing code, refactoring existing code, adding reports)
Added code to Patient Data
What did you learn from the changes you have made?
I leaned some Python coding
Was there another approach you were thinking about making? If so, what approach(es) were you thinking of?
Were there any challenges? If so, what issue(s) did you face? How did you overcome it?
I kept getting error messages when I entered the path to the file. I sought help.
How were these changes tested?
By running the code.
A reference to a related issue in your repository (if applicable)
Checklist