Make +, ==, !=, eqs, neqs work for non-string/bigdecimal arguments#42
Merged
Phergus merged 1 commit intoRPTools:developfrom Jul 10, 2020
Merged
Make +, ==, !=, eqs, neqs work for non-string/bigdecimal arguments#42Phergus merged 1 commit intoRPTools:developfrom
Phergus merged 1 commit intoRPTools:developfrom
Conversation
Makes these operators backwards compatible when expressions use java objects (like json in MapTool), e.g.
[r: "test" + json.set("{}", "property", "value")]
Add unit tests for simple string + object combinations
Upgrade gradle
fixes #1898
Contributor
Author
|
@cwisniew Craig, have a chance to review? thx |
cwisniew
approved these changes
Jul 10, 2020
Member
cwisniew
left a comment
There was a problem hiding this comment.
Reviewed 8 of 8 files at r1.
Reviewable status:complete! all files reviewed, all discussions resolved
Phergus
added a commit
to Phergus/maptool
that referenced
this pull request
Jul 10, 2020
Bump to parser v1.8.1 to pick up fixes for comparing/concatenating. RPTools/parser#42
This was referenced Jul 10, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Makes these operators backwards compatible when expressions use java objects (like json in MapTool), e.g.
[r: "test" + json.set("{}", "property", "value")]
Add unit tests for simple string + object combinations
Upgrade gradle
fixes #1898
This change is