Open
Conversation
dwz92
suggested changes
Sep 11, 2024
dwz92
left a comment
There was a problem hiding this comment.
A few things:
Both part 1 and 2 of your function is wrong. You should be writing functions that user can pass in any two strings and compare if they are anagrams. Part 1 asks you for a function that doesn't check for sensitivity, and part 2 asks you to handle the case where user can choose if sensitivity matters.
I have left comments on your shell assignment that you need to fix, please do so before Sept. 12.
|
Assignment2 is missing. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes are you trying to make? (e.g. Adding or removing code, refactoring existing code, adding reports)
Adding code
What did you learn from the changes you have made?
sorting
Was there another approach you were thinking about making? If so, what approach(es) were you thinking of?
None
Were there any challenges? If so, what issue(s) did you face? How did you overcome it?
I didn't do the assignment in the branch, did it in main, hence nothing to compare. LS helped out.
How were these changes tested?
A reference to a related issue in your repository (if applicable)
Checklist
Yes