Skip to content

[DynamicArray] Create signal on every 'dynamicArray.signal()' call & avoid retain-cycle.#24

Merged
inamiy merged 1 commit intomasterfrom
fix/DynamicArray
Mar 23, 2015
Merged

[DynamicArray] Create signal on every 'dynamicArray.signal()' call & avoid retain-cycle.#24
inamiy merged 1 commit intomasterfrom
fix/DynamicArray

Conversation

@inamiy
Copy link
Copy Markdown
Member

@inamiy inamiy commented Mar 23, 2015

Continuing #23.

  • Create a new signal for each dynamicArray.signal() call rather than reusing it
  • Fix retain cycle: ForwardingDynamicArray -> forwardingSignal -> KVOProxy -> ForwardingDynamicArray (boldface must be avoided)
    • Use ForwardingDynamicArray's public convenience init(object: NSObject, keyPath: String) instead.

inamiy added a commit that referenced this pull request Mar 23, 2015
[DynamicArray] Create signal on every 'dynamicArray.signal()' call & avoid retain-cycle.
@inamiy inamiy merged commit 7abe086 into master Mar 23, 2015
@inamiy inamiy deleted the fix/DynamicArray branch March 23, 2015 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant