Fix memory leak in bounded ReplaySubject due to retaining the node index#1866
Merged
benjchristensen merged 1 commit intoReactiveX:1.xfrom Nov 15, 2014
Merged
Conversation
indefinitely once the Subscriber caught up.
Member
|
This test failed both times: No idea why or if it's related, but I'd like to understand before merging this. |
Member
Author
|
I don't think MergeDelayError uses ReplaySubject. I don't fully understand the OperatorMerge, but it contains a lot of mutable variables and synchronized blocks and I'm not sure but I found some anomalies in: It synchronizes on the MergeProducer's this but reads the MergeSubscriber's |
Member
|
I've tested things locally and it's working for me. |
Member
|
I opened an issue to track the issue you brought up regarding |
benjchristensen
added a commit
that referenced
this pull request
Nov 15, 2014
Fix memory leak in bounded ReplaySubject due to retaining the node index
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
indefinitely once the Subscriber caught up.
For issue #1865.