Fix the issue that Sample doesn't call 'unsubscribe'#1965
Merged
benjchristensen merged 1 commit intoReactiveX:1.xfrom Dec 15, 2014
Merged
Fix the issue that Sample doesn't call 'unsubscribe'#1965benjchristensen merged 1 commit intoReactiveX:1.xfrom
benjchristensen merged 1 commit intoReactiveX:1.xfrom
Conversation
Member
|
Unfortunately, this makes the following program hang: Observable.range(0, 100).subscribeOn(Schedulers.io())
.concatMap(e -> Observable.timer(100, TimeUnit.MILLISECONDS).map(f -> e))
.sample(1000, TimeUnit.MILLISECONDS)
.delay(1000, TimeUnit.MILLISECONDS)
.toBlocking().forEach(System.out::println);
System.out.println("Done");Having: Makes the example work. |
6c958e3 to
522ce79
Compare
Member
Author
|
I see, it doesn't work with |
Member
|
Correct, it should not chain them together as it will unsubscribe up and down the stream. If it wants to unsubscribe up then it must decouple the chain. |
Member
benjchristensen
added a commit
that referenced
this pull request
Dec 15, 2014
Fix the issue that Sample doesn't call 'unsubscribe'
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #1958