Modernize gradle plugin block, change maven to maven-publish#7219
Merged
akarnokd merged 2 commits intoReactiveX:3.xfrom Mar 26, 2021
Merged
Modernize gradle plugin block, change maven to maven-publish#7219akarnokd merged 2 commits intoReactiveX:3.xfrom
akarnokd merged 2 commits intoReactiveX:3.xfrom
Conversation
Move gradle plugins to block at top of file per gradle recommendations. Change deprecated maven plugin to maven-publish as in Gradle 7.0 it will be removed. Several other minor updates to gradle file including, removing semi-colons, changing println to use built-in logger.
Codecov Report
@@ Coverage Diff @@
## 3.x #7219 +/- ##
============================================
+ Coverage 99.50% 99.56% +0.05%
+ Complexity 6757 6756 -1
============================================
Files 747 747
Lines 47391 47391
Branches 6382 6382
============================================
+ Hits 47157 47183 +26
+ Misses 105 93 -12
+ Partials 129 115 -14 Continue to review full report at Codecov.
|
akarnokd
previously approved these changes
Mar 26, 2021
akarnokd
reviewed
Mar 26, 2021
akarnokd
approved these changes
Mar 26, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move gradle plugins to block at top of file per gradle recommendations.
Change deprecated maven plugin to maven-publish as in Gradle 7.0 it will
be removed. Several other minor updates to gradle file including, removing
semi-colons, changing println to use built-in logger.