Merged
Conversation
davidebbo
reviewed
Jun 6, 2023
c662fe7 to
ebce4b2
Compare
Collaborator
Author
|
I have made several other modernizations:
I can also help if you want to setup GitHub actions to build + test + deploy a new version of the NuGet package. |
1. Update target frameworks * Drop .NET Standard below 2.0 * Update .NET Framework from 4.5 to 4.6.2 * Add .NET 6 2. Cleanup projects and code 3. Add global.json
Dropping target frameworks is a breaking change, so the major version must be incremented. Also, `AssemblyName` can be removed since it defaults to the project name.
* Remove redundant `PackageId` (it defaults to `AssemblyName` which itself defaults to the project name) * Use `PackageLicenseExpression` instead of the deprecated `PackageLicenseUrl` * Pack the README file
They have been obsolete for 4 years so a new major version is the opportunity to get rid of them.
Also improve the build-nuget script to validate the produced nupkg file.
Collaborator
|
@0xced Doing the GitHub action would be great, and good learning for me. BTW, I emailed you yesterday, asking if you wanted to become contributor, given the limited active support that I can provide. |
Collaborator
|
I already have an Azure pipelines for this, but I should modernize it a bit. Maybe a GitHub pipeline makes more sense, but we'll see. I'll give this a run through locally and then push out a new version to NuGet later today :) |
Collaborator
|
Thanks @jvandertil ! I'm meeting with @0xced at 9pm cest (I think your time zone too?). Would you like to join? I messaged you on twitter as well. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cleanup projects and code
Add global.json