Set the backing field for _inherited_ get-only properties#36
Merged
jvandertil merged 1 commit intoReflectionMagic:masterfrom Jan 29, 2024
Merged
Conversation
Pull request ReflectionMagic#34 introduced setting the backing field for get-only properties but forgot about inheritance.
858af3a to
f1c155e
Compare
davidebbo
reviewed
Jan 23, 2024
davidebbo
approved these changes
Jan 23, 2024
Collaborator
|
Change looks good. @jvandertil I think you made the release last time. Any chance you can do this one as well? Thanks! |
jvandertil
approved these changes
Jan 23, 2024
Collaborator
Yes, can do. I'll take a look later today :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commit 2a237e5 introduced setting the backing field for get-only properties but forgot about inheritance.