changes to support async remote loading of surveys#401
Merged
liujoshua merged 6 commits intoResearchStack:developfrom Nov 8, 2017
Merged
changes to support async remote loading of surveys#401liujoshua merged 6 commits intoResearchStack:developfrom
liujoshua merged 6 commits intoResearchStack:developfrom
Conversation
This was referenced Nov 4, 2017
| */ | ||
| protected void startCustomTask(SchedulesAndTasksModel.TaskScheduleModel task) { | ||
| // TODO: figure out a different way to show do these in loadTask | ||
| if (task.taskID.equals(APHTappingActivitySurveyIdentifier)) { |
Contributor
There was a problem hiding this comment.
I'd suggest making this method abstract and moving the contents to mPower
Contributor
|
Looks good 👍 |
liujoshua
approved these changes
Nov 7, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactors DataProvider and ActivitiesFragment to enable async loading of remote surveys. Added Factories to facilitate unit tests.
Testing done: