feature/stepResultHelper#402
Merged
liujoshua merged 1 commit intoResearchStack:developfrom Nov 12, 2017
Merged
Conversation
Collaborator
DwayneJengSage
left a comment
There was a problem hiding this comment.
Should we add unit tests to StepResultHelperTests? What are the requirements on testing null checks for args? Should we have a test case for both the found case and not found case?
Contributor
Author
|
Unit tests already exist for the methods in this class see StepResultHelperTest. The method I added just piggy backs off another method, I could add a unit test but don't really see the value |
DwayneJengSage
approved these changes
Nov 10, 2017
Collaborator
DwayneJengSage
left a comment
There was a problem hiding this comment.
As long as it's been tested one way or another, it looks fine to me.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added findStringResult method