Support for additional TaskModel Survey element fields#485
Merged
dephillipsmichael merged 7 commits intoResearchStack:developfrom Oct 16, 2018
Merged
Support for additional TaskModel Survey element fields#485dephillipsmichael merged 7 commits intoResearchStack:developfrom
dephillipsmichael merged 7 commits intoResearchStack:developfrom
Conversation
liujoshua
reviewed
Oct 16, 2018
| public class ChoiceQuestionSurveyItem extends QuestionSurveyItem<Choice> { | ||
| /* Default constructor needed for serilization/deserialization of object */ | ||
| ChoiceQuestionSurveyItem() { | ||
| public ChoiceQuestionSurveyItem() { |
Collaborator
There was a problem hiding this comment.
Do we need to increase visibility of these constructors?
Contributor
Author
There was a problem hiding this comment.
Yes, otherwise there are no constructors for it (only GSON)
liujoshua
reviewed
Oct 16, 2018
| //-*-*-*-*-*-*-*-*-*-*-*-*-*-*-*-*-*-*-*-*-*-*-*-*-*-*-*-*-*-*-*-*-*-*-*-*-*-*-*-*-*-*-*-*-*-*-* | ||
| private QuestionStep step; | ||
| private StepResult<String> result; | ||
| protected QuestionStep step; |
Collaborator
There was a problem hiding this comment.
Do we need to increase visibility? Should we make the step and result fields final?
Contributor
Author
There was a problem hiding this comment.
Yes, sub-classes should have access to these.
liujoshua
approved these changes
Oct 16, 2018
Collaborator
liujoshua
left a comment
There was a problem hiding this comment.
LGTM, just some questions around visibility
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.