Skip to content

Feature/example app integration#507

Open
jdkizer9 wants to merge 5 commits intoResearchStack:develop-1.5from
jdkizer9:feature/example-app-integration
Open

Feature/example app integration#507
jdkizer9 wants to merge 5 commits intoResearchStack:develop-1.5from
jdkizer9:feature/example-app-integration

Conversation

@jdkizer9
Copy link
Collaborator

Added example apps for foundation, backbone, and skin

Copy link

@syoung-smallwisdom syoung-smallwisdom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have a concern about the inclusion of Bridge server access in the skin sample. Can that be refactored out and replaced with a "dummy" service or a debug print of the request/response?

* This is a very simple implementation that hits only part of the Sage Bridge REST API
* a complete port of the Sage Bridge Java SDK for android: https://github.com/Sage-Bionetworks/BridgeJavaSDK
*/
public abstract class BridgeDataProvider extends DataProvider

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is Sage being used here as an example of how you could connect to services?

I'm curious about this b/c we do have an SDK for talking to rest services on Android, but I don't think we want this repo to point to that, yeah?

I kinda feel like an app that talks to services isn't a good choice for the base repo b/c those services change over time and it's kind of confusing to have a sample app that doesn't actually run.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Deprecated BridgeDataProvider and added comment that it should not be used. Note that Skin itself (and presumably Skin sample app) is deprecated.

Deprecated BridgeDataProvider and added comment that it's only here for historical purposes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants