Fix: Make permission group operations case-insensitive (#107)#135
Merged
sunnamed434 merged 2 commits intoRocketModFix:masterfrom Aug 24, 2025
Merged
Conversation
- Fixed RemovePlayerFromGroup to use case-insensitive comparison - Fixed AddPlayerToGroup duplicate check to be case-insensitive - Fixed GetGroups member lookup to be case-insensitive - Fixed SaveGroup and AddGroup to use case-insensitive ID comparison - Resolves issue RocketModFix#107 where permissions couldn't be removed due to case sensitivity
f307818 to
bbe8c85
Compare
Member
|
@rocketmodfix/rmfixteam what do you think guys? For me it looks good. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Changes
RemovePlayerFromGroupto useStringComparison.CurrentCultureIgnoreCaseAddPlayerToGroupduplicate check to be case-insensitiveGetGroupsmember lookup to be case-insensitiveTesting
Fixes #107