Skip to content

assignment_1.ipynb#1

Open
Rohan2677 wants to merge 2 commits intomainfrom
assignment-1
Open

assignment_1.ipynb#1
Rohan2677 wants to merge 2 commits intomainfrom
assignment-1

Conversation

@Rohan2677
Copy link
Copy Markdown
Owner

What changes are you trying to make? (e.g. Adding or removing code, refactoring existing code, adding reports)

What did you learn from the changes you have made?

Was there another approach you were thinking about making? If so, what approach(es) were you thinking of?

Were there any challenges? If so, what issue(s) did you face? How did you overcome it?

How were these changes tested?

A reference to a related issue in your repository (if applicable)

Checklist

  • I can confirm that my changes are working as intended

Copy link
Copy Markdown

@juliagallucci juliagallucci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good. You're almost there! Part A should only return a boolean (True/False). For part B, one note for improvement would be you don’t need if/else for the actual comparison, since sorted(word_a) == sorted(word_b) already returns True or False. Please revise

Copy link
Copy Markdown

@juliagallucci juliagallucci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants