acls: sync type for orig_umask and clear macOS compilation warnings#614
Merged
tridge merged 1 commit intoRsyncProject:masterfrom Nov 13, 2024
Merged
acls: sync type for orig_umask and clear macOS compilation warnings#614tridge merged 1 commit intoRsyncProject:masterfrom
tridge merged 1 commit intoRsyncProject:masterfrom
Conversation
Since 0527893 (- Call mkdir_defmode() instead of do_mkdir(). - Define orig_umask in this file, not options.c. - Made orig_umask a mode_t, not an int., 2006-02-24), the type for the global was changed, and therefore on systems where sizeof(mode_t) != sizeof(int), writes or reads to them will overflow to adjacent bytes. Change the type to the one used everywhere else and avoid this problem. While at it, silence again a warning that is being triggered by Apple's clang 15.
tridge
approved these changes
Nov 13, 2024
Member
|
@carenas apologies for the slow response |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When sizeof(mode_t) != sizeof(int) it will result in unintentional reads of global memory as shown when running the tests with sanitizers:
While at it, silence again a warning that is being triggered by Apple's Clang 15.