Add reversed builtin and range.__reversed__#385
Merged
windelbouwman merged 3 commits intoRustPython:masterfrom Feb 9, 2019
Merged
Add reversed builtin and range.__reversed__#385windelbouwman merged 3 commits intoRustPython:masterfrom
windelbouwman merged 3 commits intoRustPython:masterfrom
Conversation
0960e46 to
1ebacaf
Compare
Contributor
|
@OddCoincidence thank you for your contribution, there appear to be some merge conflicts, could you take a look at those? |
windelbouwman
suggested changes
Feb 9, 2019
Contributor
windelbouwman
left a comment
There was a problem hiding this comment.
Please take a look at the merge conflicts, then we can merge this work.
Contributor
Author
|
Conflicts resolved, and I also removed the direct uses of magic methods from the snippet as requested in #410 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For #293