Allow update __class__ for mutable types or module subclasses#5225
Merged
youknowone merged 3 commits intoRustPython:mainfrom Apr 14, 2024
Merged
Allow update __class__ for mutable types or module subclasses#5225youknowone merged 3 commits intoRustPython:mainfrom
__class__ for mutable types or module subclasses#5225youknowone merged 3 commits intoRustPython:mainfrom
Conversation
e17f303 to
802e045
Compare
__class__ for module subclasses__class__ for mutable types or module subclasses
youknowone
approved these changes
Apr 14, 2024
Member
youknowone
left a comment
There was a problem hiding this comment.
Thank you, and welcome back!
This was referenced Apr 14, 2024
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This pull request is related with #5105. The error was raised when executing the below lines:
I thought it is because RustPython doesn't allow update even if the
valueis module's subclass. This pull request just updates it.CPython implementation