READY FOR REVIEW

Summary

The "Expected return" and "Retirement length" inputs are shared between both tabs — they appear regardless of which tab is active. But the guard only exempts currentSavings and yearsToRetirement from resetting isCalculated:

So when the user changes expectedReturn or retirementLength while on the savings tab, setIsCalculated(false) fires, which:

Resets the results display to show "—"
Disables the savings tab
Forces the user back to the balance tab since isCalculated is now false
The fix: when the user is on the savings tab, don't reset isCalculated for shared inputs.

We also address the issue in IFDM-117, by removing “Expected length of retirement” only on Annual Savings tab

Review By (Date)

• When does this need to be reviewed by?

Criticality

• How critical is this PR on a 1-10 scale? See Severity Assessment.
• E.g., it affects one site, or every site and product?

Review Tasks

Setup tasks and/or behavior to test

1. Check out this branch
2. Navigate to...
3. Verify...

Front End Validation

• Is the markup using the appropriate semantic tags and passes HTML validation?
• Cross-browser testing has been performed?
• Automated accessibility scans performed?
• Manual accessibility tests performed?
• Design is approved by @ user?

Backend / Functional Validation

Code

• Are the naming conventions following our standards?
• Does the code have sufficient inline comments?
• Is there anything in this code that would be hidden or hard to discover through the UI?
• Are there any code smells?
• Are tests provided? eg (unit, behat, or codeception)

Code security

• Are all forms properly sanitized?
• Any obvious security flaws or new areas for attack?

General

• Is there anything included in this PR that is not related to the problem it is trying to solve?
• Is the approach to the problem appropriate?

Affected Projects or Products

• Does this PR impact any particular projects, products, or modules?

Associated Issues and/or People

• JIRA ticket(s)
• Other PRs
• Any other contextual information that might be helpful (e.g., description of a bug that this PR fixes, new functionality that it adds, etc.)
• Anyone who should be notified? (@mention them here)

Resources

• AMP Tool
• Accessibility Manual Test Script
• HTML Validator
• Browserstack and link to Browserstack Credentials