Skip to content

IFDM-118: fixed bug with zero in downpayment field#77

Open
imonroe wants to merge 1 commit into1.xfrom
IFDM-118
Open

IFDM-118: fixed bug with zero in downpayment field#77
imonroe wants to merge 1 commit into1.xfrom
IFDM-118

Conversation

@imonroe
Copy link
Collaborator

@imonroe imonroe commented Mar 25, 2026

READY FOR REVIEW

  • (Edit the above to reflect status)

Summary

Fixed bug where if you reduce the downpayment variable to zero, the zero is then prepended to any other value and has to be deleted.

Review By (Date)

  • When does this need to be reviewed by?

Criticality

  • How critical is this PR on a 1-10 scale? See Severity Assessment.
  • E.g., it affects one site, or every site and product?

Review Tasks

Setup tasks and/or behavior to test

  1. Check out this branch
  2. Navigate to...
  3. Verify...

Front End Validation

  • Is the markup using the appropriate semantic tags and passes HTML validation?
  • Cross-browser testing has been performed?
  • Automated accessibility scans performed?
  • Manual accessibility tests performed?
  • Design is approved by @ user?

Backend / Functional Validation

Code

  • Are the naming conventions following our standards?
  • Does the code have sufficient inline comments?
  • Is there anything in this code that would be hidden or hard to discover through the UI?
  • Are there any code smells?
  • Are tests provided? eg (unit, behat, or codeception)

Code security

General

  • Is there anything included in this PR that is not related to the problem it is trying to solve?
  • Is the approach to the problem appropriate?

Affected Projects or Products

  • Does this PR impact any particular projects, products, or modules?

Associated Issues and/or People

  • JIRA ticket(s)
  • Other PRs
  • Any other contextual information that might be helpful (e.g., description of a bug that this PR fixes, new functionality that it adds, etc.)
  • Anyone who should be notified? (@mention them here)

Resources

@imonroe imonroe requested a review from jenbreese March 25, 2026 18:00
Copy link
Collaborator

@jenbreese jenbreese left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It works great on the downpayment. Can you do the same to the other fields as well? The Optional fields need it too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants