Conversation
InClassProject_W2_2Truths_1Lie
| <main class="main"> | ||
| <!-- how will you mark up your media objects --> | ||
| <section class="azan"> | ||
| <div class="name"> |
There was a problem hiding this comment.
You could use a <header> here instead of a <div>, the <header> tag is not just for the header of the page.
| transition: 0.5s; | ||
| padding-top: 10px; | ||
| } | ||
| .azan:hover { |
There was a problem hiding this comment.
This style rule is the same as .abed:hover you could have added a class to both elements in the DOM and used a single style rule.
| } | ||
|
|
||
| @media screen and (max-width: 700px) { | ||
| main { |
There was a problem hiding this comment.
main {
grid-template-columns: 0 1fr 0;
grid-template-areas:
". azan ."
". abed .";
}
| <!-- how will you mark up your media objects --> | ||
| <section class="azan"> | ||
| <div class="name"> | ||
| <img src="img/download (1).jpg" /> |
There was a problem hiding this comment.
Your app is failing Accessibility in Lighthouse because you do not have alt attributes in your images. If you know the size of the source images you intend to use. You should set the image elements height and width to match. This way the browser creates the correct amount of space for the image while it waits for the image to load. This preserves the intended layout should the image src fail to load and also reduces "jank" which improves UX.
InClassProject_W2_2Truths_1Lie