Northwest 4 - Omer Yamak - HTML/CSS Week 2 - 2 Truths 1 Lie #3
Open
omerffaruk wants to merge 6 commits intoSallyMcGrath:mainfrom
Open
Northwest 4 - Omer Yamak - HTML/CSS Week 2 - 2 Truths 1 Lie #3omerffaruk wants to merge 6 commits intoSallyMcGrath:mainfrom
omerffaruk wants to merge 6 commits intoSallyMcGrath:mainfrom
Conversation
html structure and basic css style added. Issues to solve: html structure not ready, page layout not ready - issues to solve with flexbox
layout issues with grid and flexbox solved. issues to solve: pick a nice backgroun color, add media queries
layout changes, background color selected. Issues to solve: media queries, transition and hover could be added
media queries added, accessibility issues solved. to improve: hover and transition features, design improvements
paragraph added to the header
divs replaced with semantic html elements (section) and css adjusted accordingly
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.