Correct FMG routine to start prolongation at the proper level#124
Merged
julianlitz merged 5 commits intomainfrom Sep 23, 2025
Merged
Correct FMG routine to start prolongation at the proper level#124julianlitz merged 5 commits intomainfrom
julianlitz merged 5 commits intomainfrom
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #124 +/- ##
==========================================
+ Coverage 85.31% 85.38% +0.06%
==========================================
Files 76 76
Lines 4364 4364
==========================================
+ Hits 3723 3726 +3
+ Misses 641 638 -3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
julianlitz
commented
Sep 22, 2025
AbdelhadiKara
approved these changes
Sep 23, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The FMG routine previously started the FMG interpolation from the wrong level and accessed uninitialized data.
With this mistake corrected, the number of total iterations is significantly reduced when the number of multigrid levels is small.
Example
Before:
Full-Multigrid: 2x F(1,1)-Cycle
Start depth: 3
Solve depth: 3
Interpolate from: 2 to 1
Apply MGC on : 1
Apply MGC on : 1
Interpolate from: 1 to 0
Apply MGC on : 0
Apply MGC on : 0
After:
Full-Multigrid: 2x F(1,1)-Cycle
Start depth: 3
Solve depth: 3
Interpolate from: 3 to 2
Apply MGC on : 2
Apply MGC on : 2
Interpolate from: 2 to 1
Apply MGC on : 1
Apply MGC on : 1
Interpolate from: 1 to 0
Apply MGC on : 0
Apply MGC on : 0
Merge Request - GuideLine Checklist
Guideline to check code before resolve WIP and approval, respectively.
As many checkboxes as possible should be ticked.
Checks by code author:
Always to be checked:
If functions were changed or functionality was added:
If new functionality was added:
If new third party software is used:
If new mathematical methods or epidemiological terms are used:
Checks by code reviewer(s):