Skip to content

60 Memory error when creating fine anisotropic grid#61

Merged
mknaranja merged 4 commits intomainfrom
60-memory-error-for-nr_exp-=-fac_ani-+1-fac_ani-3-and-alpha_coeff-=-0-or-2
Jun 6, 2024
Merged

60 Memory error when creating fine anisotropic grid#61
mknaranja merged 4 commits intomainfrom
60-memory-error-for-nr_exp-=-fac_ani-+1-fac_ani-3-and-alpha_coeff-=-0-or-2

Conversation

@CodingAllan
Copy link
Copy Markdown
Member

@CodingAllan CodingAllan commented Apr 25, 2024

Merge Request - GuideLine Checklist

Implemented small fix where iterator could go out of bounds in creating anisotropic grid. This was the case, when nr_exp=fac_ani+1 and fac_ani>3 with alpha_coeff either being 0 or 2.

Guideline to check code before resolve WIP and approval, respectively.
As many checkboxes as possible should be ticked.

Checks by code author:

Always to be checked:

  • There is at least one issue associated with the pull request.
  • New code adheres with the coding guidelines
  • No large data files have been added to the repository. Maximum size for files should be of the order of KB not MB. In particular avoid adding of pdf, word, or other files that cannot be change-tracked correctly by git.

If functions were changed or functionality was added:

  • Tests for new functionality has been added
  • A local test was succesful

If new functionality was added:

  • There is appropriate documentation of your work. (use doxygen style comments)

If new third party software is used:

  • Did you pay attention to its license? Please remember to add it to the wiki after successful merging.

If new mathematical methods or epidemiological terms are used:

  • Are new methods referenced? Did you provide further documentation?

[ ] The following questions are addressed in the documentation (if need be):

  • Developers (what did you do?, how can it be maintained?)

  • For users (how to use your work?)

  • For admins (how to install and configure your work?)

  • For documentation: Please write or update the Readme in the current working directory!

Checks by code reviewer(s):

  • Is the code clean of development artifacts e.g., unnecessary comments, prints, ...
  • The ticket goals for each associated issue are reached or problems are clearly addressed (i.e., a new issue was introduced).
  • There are appropriate unit tests and they pass.
  • The git history is clean and linearized for the merge request. All reviewers should squash commits and write a simple and meaningful commit message.
  • Coverage report for new code is acceptable.
  • No large data files have been added to the repository. Maximum size for files should be of the order of KB not MB. In particular avoid adding of pdf, word, or other files that cannot be change-tracked correctly by git.

@CodingAllan CodingAllan linked an issue Apr 25, 2024 that may be closed by this pull request
@CodingAllan CodingAllan changed the title small fix where iterator could go out of bounds in creating anisotropic grid small fix where iterator could go out of bounds in creating anisotropic grid for nr_exp=fac_ani+1 and fac_ani>3, alpha_coeff=0 or 2 Apr 25, 2024
@CodingAllan CodingAllan requested a review from mknaranja April 25, 2024 12:06
@mknaranja mknaranja changed the title small fix where iterator could go out of bounds in creating anisotropic grid for nr_exp=fac_ani+1 and fac_ani>3, alpha_coeff=0 or 2 60 Memory error when creating fine anisotropic grid Apr 25, 2024
@mknaranja
Copy link
Copy Markdown
Member

@CodingAllan Please try to give it a simple (as with the issue) and provide details in the description ;-)

Copy link
Copy Markdown
Member

@mknaranja mknaranja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix. Please check and apply my suggestions if you agree.

Comment thread src/create_grid_polar.cpp Outdated
Comment thread src/create_grid_polar.cpp
Comment thread src/create_grid_polar.cpp Outdated
@CodingAllan CodingAllan requested a review from mknaranja May 24, 2024 08:31
@mknaranja
Copy link
Copy Markdown
Member

Hi @CodingAllan, I have now seen that there was a code shortly after my last review. Please request the review once changes are made, verify that all comments are addressed and answer on the opened conversations. Actually it looks like if two comments have been ignored?

@CodingAllan
Copy link
Copy Markdown
Member Author

@mknaranja , yes I just remembered that this was not merged yet and hence requested a review.

I commented on the suggestions you made and just wanted to ask if the way of correcting is acceptable.
Im not sure if I am missing something.. but I did not ignore anything ?

@CodingAllan
Copy link
Copy Markdown
Member Author

@mknaranja , yes I just remembered that this was not merged yet and hence requested a review.

I commented on the suggestions you made and just wanted to ask if the way of correcting is acceptable. Im not sure if I am missing something.. but I did not ignore anything ?

I am sorry, I accidentally marked a conversation as resolved.

@mknaranja mknaranja merged commit 4688f6f into main Jun 6, 2024
@mknaranja mknaranja deleted the 60-memory-error-for-nr_exp-=-fac_ani-+1-fac_ani-3-and-alpha_coeff-=-0-or-2 branch June 6, 2024 12:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Memory error when creating fine anisotropic grid

2 participants