Skip to content

1006 Prevent NaNs in SDE models#1008

Merged
mknaranja merged 1 commit intomainfrom
1006-sde-models-have-different-step-sizes
Apr 19, 2024
Merged

1006 Prevent NaNs in SDE models#1008
mknaranja merged 1 commit intomainfrom
1006-sde-models-have-different-step-sizes

Conversation

@reneSchm
Copy link
Copy Markdown
Member

@reneSchm reneSchm commented Apr 18, 2024

as with some parameters flows may attain negative values

Changes and Information

Please briefly list the changes (main added features, changed items, or corrected bugs) made:

  • Bound flows in SDE models from below.

If need be, add additional information and what the reviewer should look out for in particular:

-/-

Merge Request - Guideline Checklist

Please check our git workflow. Use the draft feature if the Pull Request is not yet ready to review.

Checks by code author

  • Every addressed issue is linked (use the "Closes #ISSUE" keyword below)
  • New code adheres to coding guidelines
  • No large data files have been added (files should in sum not exceed 100 KB, avoid PDFs, Word docs, etc.)
  • Tests are added for new functionality and a local test run was successful (with and without OpenMP)
  • Appropriate documentation for new functionality has been added (Doxygen in the code and Markdown files if necessary)
  • Proper attention to licenses, especially no new third-party software with conflicting license has been added
  • (For ABM development) Checked benchmark results and ran and posted a local test above from before and after development to ensure performance is monitored.

Checks by code reviewer(s)

  • Corresponding issue(s) is/are linked and addressed
  • Code is clean of development artifacts (no deactivated or commented code lines, no debugging printouts, etc.)
  • Appropriate unit tests have been added, CI passes, code coverage and performance is acceptable (did not decrease)
  • No large data files added in the whole history of commits(files should in sum not exceed 100 KB, avoid PDFs, Word docs, etc.)
  • On merge, add 2-5 lines with the changes (main added features, changed items, or corrected bugs) to the merge-commit-message. This can be taken from the briefly-list-the-changes above (best case) or the separate commit messages (worst case).

as with some parameters flows may attain negative values
@reneSchm reneSchm added loc::backend This issue concerns the C++ backend implementation. model::sde This issue concerns any kind of stochastic differential equation-based model. labels Apr 18, 2024
@reneSchm reneSchm self-assigned this Apr 18, 2024
@reneSchm reneSchm linked an issue Apr 18, 2024 that may be closed by this pull request
2 tasks
@reneSchm reneSchm requested review from mknaranja and nijawa and removed request for nijawa April 18, 2024 14:49
@codecov
Copy link
Copy Markdown

codecov bot commented Apr 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.34%. Comparing base (579ea34) to head (4bd4e6d).
Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1008   +/-   ##
=======================================
  Coverage   96.34%   96.34%           
=======================================
  Files         129      129           
  Lines       10064    10071    +7     
=======================================
+ Hits         9696     9703    +7     
  Misses        368      368           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mknaranja mknaranja merged commit a245aee into main Apr 19, 2024
@mknaranja mknaranja deleted the 1006-sde-models-have-different-step-sizes branch April 19, 2024 13:19
@mknaranja mknaranja changed the title Prevent NaNs in SDE models 1006 Prevent NaNs in SDE models Apr 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

loc::backend This issue concerns the C++ backend implementation. model::sde This issue concerns any kind of stochastic differential equation-based model.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

SDE Models have different step sizes

2 participants