Skip to content

1016 use interpolate_simulation_result for timeseries in secirvvs python#1017

Merged
HenrZu merged 1 commit intomainfrom
1016-interpolate_simulation_result-not-working-for-secirvvs-in-pycode
Apr 29, 2024
Merged

1016 use interpolate_simulation_result for timeseries in secirvvs python#1017
HenrZu merged 1 commit intomainfrom
1016-interpolate_simulation_result-not-working-for-secirvvs-in-pycode

Conversation

@HenrZu
Copy link
Copy Markdown
Contributor

@HenrZu HenrZu commented Apr 25, 2024

Changes and Information

Please briefly list the changes (main added features, changed items, or corrected bugs) made:

  • added bindings to be able to use the interpolate_simulation_result with a timeseries obtained by a secirvvs simulation

If need be, add additional information and what the reviewer should look out for in particular:

Merge Request - Guideline Checklist

Please check our git workflow. Use the draft feature if the Pull Request is not yet ready to review.

Checks by code author

  • Every addressed issue is linked (use the "Closes #ISSUE" keyword below)
  • New code adheres to coding guidelines
  • No large data files have been added (files should in sum not exceed 100 KB, avoid PDFs, Word docs, etc.)
  • Tests are added for new functionality and a local test run was successful (with and without OpenMP)
  • Appropriate documentation for new functionality has been added (Doxygen in the code and Markdown files if necessary)
  • Proper attention to licenses, especially no new third-party software with conflicting license has been added
  • (For ABM development) Checked benchmark results and ran and posted a local test above from before and after development to ensure performance is monitored.

Checks by code reviewer(s)

  • Corresponding issue(s) is/are linked and addressed
  • Code is clean of development artifacts (no deactivated or commented code lines, no debugging printouts, etc.)
  • Appropriate unit tests have been added, CI passes, code coverage and performance is acceptable (did not decrease)
  • No large data files added in the whole history of commits(files should in sum not exceed 100 KB, avoid PDFs, Word docs, etc.)
  • On merge, add 2-5 lines with the changes (main added features, changed items, or corrected bugs) to the merge-commit-message. This can be taken from the briefly-list-the-changes above (best case) or the separate commit messages (worst case).

@HenrZu HenrZu linked an issue Apr 25, 2024 that may be closed by this pull request
2 tasks
@codecov
Copy link
Copy Markdown

codecov bot commented Apr 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.34%. Comparing base (b3895a4) to head (ab5e870).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1017   +/-   ##
=======================================
  Coverage   96.34%   96.34%           
=======================================
  Files         129      129           
  Lines       10072    10072           
=======================================
  Hits         9704     9704           
  Misses        368      368           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@HenrZu HenrZu requested a review from jubicker April 29, 2024 08:40
@HenrZu HenrZu merged commit deefc27 into main Apr 29, 2024
@HenrZu HenrZu deleted the 1016-interpolate_simulation_result-not-working-for-secirvvs-in-pycode branch April 29, 2024 09:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

interpolate_simulation_result not working for secirvvs in pycode

2 participants