Skip to content

1042 stub generation for python bindings #1044

Merged
reneSchm merged 9 commits intomainfrom
1042-stub-generation-for-python-bindings
Jun 10, 2024
Merged

1042 stub generation for python bindings #1044
reneSchm merged 9 commits intomainfrom
1042-stub-generation-for-python-bindings

Conversation

@MaxBetzDLR
Copy link
Copy Markdown
Member

@MaxBetzDLR MaxBetzDLR commented May 28, 2024

Changes and Information

Please briefly list the changes (main added features, changed items, or corrected bugs) made:

If need be, add additional information and what the reviewer should look out for in particular:

Merge Request - Guideline Checklist

Please check our git workflow. Use the draft feature if the Pull Request is not yet ready to review.

Checks by code author

  • Every addressed issue is linked (use the "Closes #ISSUE" keyword below)
  • New code adheres to coding guidelines
  • No large data files have been added (files should in sum not exceed 100 KB, avoid PDFs, Word docs, etc.)
  • Tests are added for new functionality and a local test run was successful (with and without OpenMP)
  • Appropriate documentation for new functionality has been added (Doxygen in the code and Markdown files if necessary)
  • Proper attention to licenses, especially no new third-party software with conflicting license has been added
  • (For ABM development) Checked benchmark results and ran and posted a local test above from before and after development to ensure performance is monitored.

Checks by code reviewer(s)

  • Corresponding issue(s) is/are linked and addressed
  • Code is clean of development artifacts (no deactivated or commented code lines, no debugging printouts, etc.)
  • Appropriate unit tests have been added, CI passes, code coverage and performance is acceptable (did not decrease)
  • No large data files added in the whole history of commits(files should in sum not exceed 100 KB, avoid PDFs, Word docs, etc.)
  • On merge, add 2-5 lines with the changes (main added features, changed items, or corrected bugs) to the merge-commit-message. This can be taken from the briefly-list-the-changes above (best case) or the separate commit messages (worst case).

Closes #1042

@MaxBetzDLR MaxBetzDLR linked an issue May 28, 2024 that may be closed by this pull request
2 tasks
@codecov
Copy link
Copy Markdown

codecov bot commented May 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.23%. Comparing base (369edec) to head (0b7a53c).
Report is 1 commits behind head on main.

Current head 0b7a53c differs from pull request most recent head daec67c

Please upload reports for the commit daec67c to get more accurate results.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1044   +/-   ##
=======================================
  Coverage   96.23%   96.23%           
=======================================
  Files         128      128           
  Lines       10852    10852           
=======================================
  Hits        10443    10443           
  Misses        409      409           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@MaxBetzDLR MaxBetzDLR requested a review from reneSchm June 3, 2024 08:16
@MaxBetzDLR MaxBetzDLR self-assigned this Jun 3, 2024
Copy link
Copy Markdown
Member

@reneSchm reneSchm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, I mostly have small comments on the documentation.

Comment thread pycode/memilio-simulation/README.md Outdated
Comment thread pycode/memilio-simulation/README.md Outdated
Comment thread pycode/memilio-simulation/README.md
Comment thread pycode/memilio-simulation/CMakeLists.txt
Comment thread pycode/memilio-simulation/setup.py Outdated
Comment thread pycode/memilio-simulation/tools/generate_stubs.py Outdated
Comment thread pycode/memilio-simulation/tools/generate_stubs.py
@MaxBetzDLR MaxBetzDLR requested a review from reneSchm June 10, 2024 11:40
Comment thread pycode/memilio-simulation/setup.py
@reneSchm reneSchm merged commit 8f9a34c into main Jun 10, 2024
@reneSchm reneSchm deleted the 1042-stub-generation-for-python-bindings branch June 10, 2024 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

stub generation for python bindings

2 participants